Clover Build Fails on Admin NG

Steps to reproduce

Clover builds fail on admin ng module

% mvn clover2:setup test clover2:aggregate clover2:clover -Dcheckstyle.skip=true -Dall

Build on r/1.6.x runs through without problem.

Activity

Show:
Lars Kiesow
May 29, 2015, 2:07 PM

I oppose that proposal. But feel free to bring that up at the next technical meeting.

Lukas Rohner
May 29, 2015, 2:23 PM

Hi Lars, having three committers not happy with it is reason enough to discuss a possible different solution. Even if Greg already merged it in and we only short after the merge found it. So I really don't see why you insist here. It's not the first time something got merged in and after that got complains and has been reverted again to find a different solution making everybody happy.

Lars Kiesow
May 29, 2015, 2:47 PM

> is reason enough to discuss a possible different solution.

That is exactly what I said: Bring it up in the technical meeting so this can be discussed .
If you remember last meeting,I even mentioned that at the beginning of the last meeting and was suprised that no one brought it up.
I know, I did not but I am fine with the current state.

Yes, we reverted things that broke the build process, … afaik never something we disagreed about and this pull request certainly does not break anything.

Tobias Wunden
June 9, 2015, 10:45 PM

Hi Lars, we have continued to discuss this issue internally and decided to suggest closing the ticket unless someone has the time to actually make the tests work with Clover or find a good way to disable it if run in conjunction with Clover. There are more important things to fix.

Lars Kiesow
June 11, 2015, 2:14 PM

+1

Assignee

Lars Kiesow

Reporter

Lars Kiesow

Severity

Build Error

Tags (folksonomy)

Components

Fix versions

Affects versions

Priority

Critical
Configure