Potentially uninformative null log entries

Steps to reproduce

The log calls below are all potentially null as Throwable.getMessage() can be null. They should include more informative text preceding the message.

  1. grep -r "(e.getMessage())" modules//src/ | grep -i log

modules/matterhorn-authorization-manager/src/main/java/org/opencastproject/authorization/xacml/manager/impl/AclServiceImpl.java: logger.warn(e.getMessage());
modules/matterhorn-caption-impl/src/main/java/org/opencastproject/caption/endpoint/CaptionServiceRestEndpoint.java: logger.error(e.getMessage());
modules/matterhorn-caption-impl/src/main/java/org/opencastproject/caption/endpoint/CaptionServiceRestEndpoint.java: logger.error(e.getMessage());
modules/matterhorn-composer-ffmpeg/src/main/java/org/opencastproject/composer/impl/ffmpeg/FFmpegEmbedderEngine.java: logger.error(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/WorkflowPermissionsUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/WorkflowPermissionsUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/WorkflowPermissionsUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/ArchivePermissionsUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-conductor/src/main/java/org/opencastproject/event/handler/ArchivePermissionsUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/matterhorn-dataloader/src/main/java/org/opencastproject/dataloader/UserAndSeriesLoader.java: logger.warn(e.getMessage());
modules/matterhorn-fileupload/src/main/java/org/opencastproject/fileupload/service/FileUploadServiceCleaner.java: logger.warn(e.getMessage());
modules/matterhorn-ingest-service-impl/src/main/java/org/opencastproject/ingest/endpoint/IngestRestService.java: logger.info(e.getMessage());
modules/matterhorn-ingest-service-impl/src/main/java/org/opencastproject/ingest/endpoint/IngestRestService.java: logger.warn(e.getMessage());
modules/matterhorn-ingest-service-impl/src/main/java/org/opencastproject/ingest/endpoint/IngestRestService.java: logger.error(e.getMessage());
modules/matterhorn-inspection-service-ffmpeg/src/main/java/org/opencastproject/inspection/ffmpeg/endpoints/MediaInspectionRestEndpoint.java: logger.info(e.getMessage());
modules/matterhorn-kernel/src/main/java/org/opencastproject/kernel/security/OrganizationDirectoryServiceImpl.java: logger.error(e.getMessage());
modules/matterhorn-search-service-impl/src/main/java/org/opencastproject/search/endpoint/SearchRestService.java: logger.info(e.getMessage());
modules/matterhorn-search-service-impl/src/main/java/org/opencastproject/search/endpoint/SearchRestService.java: logger.info(e.getMessage());
modules/matterhorn-userdirectory/src/main/java/org/opencastproject/userdirectory/JpaGroupRoleProvider.java: logger.warn(e.getMessage());
modules/matterhorn-userdirectory/src/main/java/org/opencastproject/userdirectory/JpaGroupRoleProvider.java: logger.warn(e.getMessage());
modules/matterhorn-workflow-service-impl/src/main/java/org/opencastproject/workflow/impl/WorkflowOperationWorker.java: logger.info(e.getMessage());
modules/matterhorn-workflow-service-impl/src/main/java/org/opencastproject/workflow/impl/WorkflowServiceImpl.java: logger.warn(e.getMessage());

Activity

Show:
Stephen Marquard
April 19, 2019, 12:27 PM

smarquard→ opencast.git ((HEAD detached at opencast-community/develop)) ☘ # grep -r "(e.getMessage())" modules//src/ | grep -i log
modules/admin-ui/src/main/java/org/opencastproject/adminui/endpoint/GroupsEndpoint.java: logger.warn(e.getMessage());
modules/admin-ui/src/main/java/org/opencastproject/adminui/endpoint/GroupsEndpoint.java: logger.warn(e.getMessage());
modules/caption-impl/src/main/java/org/opencastproject/caption/endpoint/CaptionServiceRestEndpoint.java: logger.error(e.getMessage());
modules/caption-impl/src/main/java/org/opencastproject/caption/endpoint/CaptionServiceRestEndpoint.java: logger.error(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/WorkflowPermissionsUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/AssetManagerUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/AssetManagerUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/conductor/src/main/java/org/opencastproject/event/handler/SeriesUpdatedEventHandler.java: logger.warn(e.getMessage());
modules/dataloader/src/main/java/org/opencastproject/dataloader/UserAndSeriesLoader.java: logger.warn(e.getMessage());
modules/external-api/src/main/java/org/opencastproject/external/endpoint/GroupsEndpoint.java: logger.warn(e.getMessage());
modules/external-api/src/main/java/org/opencastproject/external/endpoint/GroupsEndpoint.java: logger.warn(e.getMessage());
modules/external-api/src/main/java/org/opencastproject/external/endpoint/GroupsEndpoint.java: logger.warn(e.getMessage());
modules/external-api/src/main/java/org/opencastproject/external/endpoint/GroupsEndpoint.java: logger.warn(e.getMessage());
modules/fileupload/src/main/java/org/opencastproject/fileupload/service/FileUploadServiceCleaner.java: logger.warn(e.getMessage());
modules/ingest-service-impl/src/main/java/org/opencastproject/ingest/endpoint/IngestRestService.java: logger.info(e.getMessage());
modules/ingest-service-impl/src/main/java/org/opencastproject/ingest/endpoint/IngestRestService.java: logger.warn(e.getMessage());
modules/ingest-service-impl/src/main/java/org/opencastproject/ingest/endpoint/IngestRestService.java: logger.error(e.getMessage());
modules/inspection-service-ffmpeg/src/main/java/org/opencastproject/inspection/ffmpeg/endpoints/MediaInspectionRestEndpoint.java: logger.info(e.getMessage());
modules/search-service-impl/src/main/java/org/opencastproject/search/endpoint/SearchRestService.java: logger.info(e.getMessage());
modules/search-service-impl/src/main/java/org/opencastproject/search/endpoint/SearchRestService.java: logger.info(e.getMessage());
modules/transcription-service-ibm-watson-impl/src/main/java/org/opencastproject/transcription/ibmwatson/endpoint/IBMWatsonTranscriptionRestService.java: logger.warn(e.getMessage());
modules/userdirectory/src/main/java/org/opencastproject/userdirectory/endpoint/GroupRoleEndpoint.java: logger.warn(e.getMessage());
modules/userdirectory/src/main/java/org/opencastproject/userdirectory/endpoint/GroupRoleEndpoint.java: logger.warn(e.getMessage());
modules/workflow-service-impl/src/main/java/org/opencastproject/workflow/impl/WorkflowOperationWorker.java: logger.info(e.getMessage());
modules/workflow-service-impl/src/main/java/org/opencastproject/workflow/impl/WorkflowServiceImpl.java: logger.warn(e.getMessage());

Karen Dolan
April 27, 2019, 6:20 PM

karendolan merged commit 133da3c into opencast:develop

Assignee

Stephen Marquard

Reporter

Stephen Marquard

Severity

Operations

Tags (folksonomy)

None

Components

Fix versions

Affects versions

Priority

Major
Configure