Uploaded image for project: 'Opencast'
  1. MH-13118

LTI series tool shows events from other series

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects versions: 4.4, 5.1
    • Fix versions: None
    • Components: RESTful Interfaces
    • Labels:
      None
    • Severity:
      Incorrectly Functioning Without Workaround
    • Steps to reproduce:
      Hide
      The LTI series tool is supposed to show recordings from a specific series, which the docs stating "To show all videos for a single series, use tool=ltitools/series/index.html;series=SERIESID", however it can end up showing recordings from other series.
      This is because the series tool makes a /search/episode.xml API call using the free-text (`q`) query parameter, when it should be using `sid`:

      4.4:
      https://github.com/opencast/opencast/blob/4.4/modules/matterhorn-lti/src/main/resources/tools/series/index.html#L45

      5.1:
      https://github.com/opencast/opencast/blob/5.1/modules/lti/src/main/resources/tools/series/index.html#L45

      If an event `A` exists and is part of a series with id `XYZ` and `XYZ` appears in free-text searchable metadata relating to event `B` (which is part of another series). Then event `B` will appear in the LTI series tool when specifying the series of XYZ for the series.

      This should be a minor change to use `sid=` instead of `q=` when making the API call, however this may break existing integrations if institutions are relying on this bug and using the free-text query to show events for a specific series.
      This has been fixed in develop[1] (soon to be Opencast 6) so any institutions that are relying on this behaviour will have a problem when upgrading in future.

      [1] https://github.com/opencast/opencast/pull/415/commits/0ede35cf7e62930a0b895e0b81f2ace2d13c5d44#diff-3a99ba8a09212687635546172fa8b163R37
      Show
      The LTI series tool is supposed to show recordings from a specific series, which the docs stating "To show all videos for a single series, use tool=ltitools/series/index.html;series=SERIESID", however it can end up showing recordings from other series. This is because the series tool makes a /search/episode.xml API call using the free-text (`q`) query parameter, when it should be using `sid`: 4.4: https://github.com/opencast/opencast/blob/4.4/modules/matterhorn-lti/src/main/resources/tools/series/index.html#L45 5.1: https://github.com/opencast/opencast/blob/5.1/modules/lti/src/main/resources/tools/series/index.html#L45 If an event `A` exists and is part of a series with id `XYZ` and `XYZ` appears in free-text searchable metadata relating to event `B` (which is part of another series). Then event `B` will appear in the LTI series tool when specifying the series of XYZ for the series. This should be a minor change to use `sid=` instead of `q=` when making the API call, however this may break existing integrations if institutions are relying on this bug and using the free-text query to show events for a specific series. This has been fixed in develop[1] (soon to be Opencast 6) so any institutions that are relying on this behaviour will have a problem when upgrading in future. [1] https://github.com/opencast/opencast/pull/415/commits/0ede35cf7e62930a0b895e0b81f2ace2d13c5d44#diff-3a99ba8a09212687635546172fa8b163R37
    • Tags (folksonomy):

      TestRail: Results

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              pmgration Paul Gration
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                TestRail: Cases