Uploaded image for project: 'Opencast'
  1. MH-13232

`ffmpeg >= 4.1` no longer allows negative values for duration-type filter parameters

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed and reviewed
    • Affects versions: 7.0
    • Fix versions: None
    • Labels:
      None
    • Severity:
      Incorrectly Functioning Without Workaround
    • Steps to reproduce:
      Hide
      `ffmpeg` added some range checking to all filter parameters which are of type duration. One such example is (strangely enough) the `start_time`/`st` parameter of the `fade` filter. In our system, this parameter can become negative, if the fade duration is longer than the faded clip itself; the start time of the fade out will then become negative.

      I have a fix for that particular case, but there might be more places where this is important.

      Currently this stops Opencast from building on systems with newer `ffmpeg`-s, because of a failing test, in which the situation described above comes up. (`org.opencastProject.composer.impl.ProcessSmilTest#testProcessSmilMultiSegment` in `composer-ffmpeg`)
      Show
      `ffmpeg` added some range checking to all filter parameters which are of type duration. One such example is (strangely enough) the `start_time`/`st` parameter of the `fade` filter. In our system, this parameter can become negative, if the fade duration is longer than the faded clip itself; the start time of the fade out will then become negative. I have a fix for that particular case, but there might be more places where this is important. Currently this stops Opencast from building on systems with newer `ffmpeg`-s, because of a failing test, in which the situation described above comes up. (`org.opencastProject.composer.impl.ProcessSmilTest#testProcessSmilMultiSegment` in `composer-ffmpeg`)

      TestRail: Results

        Attachments

          Activity

            People

            • Assignee:
              JulianKniephoff Julian Kniephoff
              Reporter:
              JulianKniephoff Julian Kniephoff
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                TestRail: Cases