Examine diffs between 1.2 and 1.3 capture agent for code changes that causes the jvm to crash

Description

I cannot reproduce the issue on 1.2 in conditions that it reliably happens in 1.3. Therefore, I am going to go through all of the commits after the svn log says the 1.2 branch happened for the capture agent bundle (modules/matterhorn-capture-agent-impl) to determine possible candidates that are issues. Then I will create tasks to revert the code and test it on capture agents to isolate what might be causing the issue.

Activity

Show:
Adam McKenzie
June 8, 2012, 1:43 PM

I verified last night with 8 recordings 1 minute apart with a duration of 1.5 hours that it was the drop frames that was causing the issue. If you want to patch the problem it is:

Index: modules/matterhorn-capture-agent-impl/src/main/java/org/opencastproject/capture/pipeline/bins/producers/EpiphanVGA2USBV4LSubPngBin.java
===================================================================
— modules/matterhorn-capture-agent-impl/src/main/java/org/opencastproject/capture/pipeline/bins/producers/EpiphanVGA2USBV4LSubPngBin.java (revision 10958)
+++ modules/matterhorn-capture-agent-impl/src/main/java/org/opencastproject/capture/pipeline/bins/producers/EpiphanVGA2USBV4LSubPngBin.java (working copy)
@@ -181,7 +181,7 @@
src.setCaps(Caps.fromString("image/png, framerate=(fraction)25/1"));
capsFilter.setCaps(Caps.fromString(caps));
sink.set(GStreamerProperties.EMIT_SIGNALS, "false");

  • sink.set(GStreamerProperties.DROP, "false");
    + sink.set(GStreamerProperties.DROP, "true");
    sink.set(GStreamerProperties.ASYNC, "true");
    sink.set(GStreamerProperties.MAX_BUFFERS, "5");
    sink.setCaps(Caps.fromString(caps));
    Index: modules/matterhorn-capture-agent-impl/src/main/java/org/opencastproject/capture/pipeline/bins/producers/EpiphanVGA2USBV4LSubTestSrcBin.java
    ===================================================================

    •  

      • modules/matterhorn-capture-agent-impl/src/main/java/org/opencastproject/capture/pipeline/bins/producers/EpiphanVGA2USBV4LSubTestSrcBin.java (revision 10958)
        +++ modules/matterhorn-capture-agent-impl/src/main/java/org/opencastproject/capture/pipeline/bins/producers/EpiphanVGA2USBV4LSubTestSrcBin.java (working copy)
        @@ -139,7 +139,7 @@
        src.set(GStreamerProperties.DO_TIMESTAP, "false");
        capsFilter.setCaps(Caps.fromString(caps));
        sink.set(GStreamerProperties.EMIT_SIGNALS, "false");

  • sink.set(GStreamerProperties.DROP, "false");
    + sink.set(GStreamerProperties.DROP, "true");
    sink.set(GStreamerProperties.ASYNC, "true");
    sink.set(GStreamerProperties.MAX_BUFFERS, "5");
    sink.setCaps(Caps.fromString(caps));

Adam McKenzie
June 14, 2012, 7:05 PM

Fix committed revision 12298.

Adam McKenzie
June 14, 2012, 7:06 PM

Please port the fix in trunk from revision 12298 to both the 1.3 and 1.4 branch.

Greg Logan
June 14, 2012, 10:19 PM

Merged in rev 12299 for 1.3.x, 12300 for 1.4.x.

Kevin K Chan
June 28, 2012, 12:22 AM

FYI, I have been doing a bunch of back to back recordings on 3 different 1.3.x agents with this patch - we have not encountered any issues so far.

Assignee

Adam McKenzie

Reporter

Adam McKenzie

Tags (folksonomy)

None

Components

Fix versions

Affects versions

Priority

Blocker
Configure