Series tab paging: Next link is enabled when it shouldn't be and displays an empty table

Steps to reproduce

Steps to reproduce:
1. Set number of series per page to 5.
2. In addition to the 10 ootb series, add 5 more so there is a total of 15
3. Use the Next link in the paging controls to page thru the pages.

Actual Results:
When on the third page (which should be the last) the Next link is enabled and when clicked, displays an empty table (see screenshot)

Expected Results:
Unable to get to an empty page.

Note that I'm also pretty sure that I saw this behavior prior to adding the extra 5. That is, when displaying 10 series per page, the Next button was enabled when there were exactly 10, and clicking it displayed an empty table.

Activity

Show:
Judy Stern
August 23, 2012, 8:46 PM

Happening in 1.4rc

Greg Logan
September 4, 2012, 4:02 PM

This was committed directly to 1.3.x, but not trunk (and hence is not in 1.4). I'll try doing the merges and hopefully this will fix it.

Greg Logan
September 24, 2012, 11:17 PM

Ok, so this doesn't merge cleanly to trunk. Resolving the merge conflict with tc and then removing the extra lines makes things mostly work in the sense that it behaves correctly with 10 series, but when you increase that to 11 the second page still has the links enabled. A small change to the third branch in the if statement resolves this for me. Committed to trunk with rev 12963, 1.4.x with rev 12964.

Tobias Schiebeck
October 10, 2012, 4:41 PM
Edited

having multiple pages a jump to last goes to page 3 of 2

The patch fixes the go to last page issue correcting a missing -1 in the link

Greg Logan
October 10, 2012, 7:32 PM

Ah, good catch. Committed to trunk with rev 13053, 1.4.x with rev 13055, 1.3.x with rev 13056.

Assignee

Tobias Schiebeck

Reporter

Judy Stern

Severity

Usability Issue

Tags (folksonomy)

Components

Fix versions

Affects versions

Priority

Minor
Configure