undefined

Steps to reproduce

I go to http://testengage.usask.ca:8080/engage/ui/watch.html?id=e3bd1149-014b-44da-8370-79463e34f453 and opened up the comments tab. Then I click on the little + in a bubble by the scrubber (using ff 18.0). Numerous issues, first, the "Type Your Comment Here" is confusing because I can't see the outlines of any of the text areas. Second, I have no idea what to do when I am done - hit enter? hit the plus button? The x? Just click off the bubble? What saves my comment.

Finally, there is a string that says "undefined" at the time stamp. Note that I haven't started the video yet, so where will this comment go? I think the colour scheme for this component could use some more eyes, it looks off to me.

Activity

Show:
Martin Abel
April 24, 2013, 1:13 PM

see patch

Greg Logan
April 24, 2013, 7:59 PM

I'm unclear what this patch is supposed to do, but the issues listed above appear to be resolved with it applied. Committed to trunk with rev 14416, merged to 1.4.x with rev 14420.

Martin Abel
April 25, 2013, 9:57 AM

The problem was the unset variable cm_username if user is not logged in. The patch sets this variable to a default value or, if the user already sets his username, the patch reads the value from the cookie value.

Greg Logan
April 25, 2013, 5:10 PM

So this ticket should be resolved then?

Greg Logan
May 7, 2013, 3:57 PM

Ruediger tells me this is resolved by the attached patch, so I'm going to resolve.

Fixed and reviewed

Assignee

Greg Logan

Reporter

Christopher Brooks

Severity

Incorrectly Functioning Without Workaround

Tags (folksonomy)

None

Components

Fix versions

Affects versions

Priority

Blocker
Configure