Test Fest: matterhorn-composer-ffmpeg / AbstractCmdlineEncoderEngineTest

Description

The AbstractCmdlineEncoderEngine class has an internal function of reading command line profiles from property files (e.g., matterhorn-movies.properties) and then splitting command line arguments per java.lang.ProcessBuilder constructor needs.

However, I found a bug. If you have a command line string with one arg that is surrounded in quotes then the result of AbstractCmdlineEncoderEngine#buildCommand(profile) is wrong. It does not respect the quotes.

For example, if the command line were:
echo "Hello World"
You'd get an arg list of { "\"Hello", "World\""} when what you really want is { "Hello World" }

I intend to commit the necessary unit tests plus a fix.

Activity

Show:
John Crossman
June 20, 2013, 1:45 AM

see modules/matterhorn-composer-ffmpeg/src/test/java/org/opencastproject/composer/impl/AbstractCmdlineEncoderEngineTest.java

Greg Logan
July 31, 2013, 5:21 PM

Merged into trunk with rev 15203, merged into 1.4.x with rev 15204.

Fixed and reviewed

Assignee

John Crossman

Reporter

John Crossman

Tags (folksonomy)

Time tracking

0m

Time remaining

1h

Components

Fix versions

Affects versions

Priority

Major
Configure