Continuing from "Hold for workflow selection" causes NPE in WorkflowOperatonWorker

Steps to reproduce

Steps to reproduce:
1. Ingest something with workflow "default" (enable it for the use with the upload panel first by adding <tags><tag>upload</tag></tags>)
2. Click "Action" on the resulting workflow in hold state
3. Click "Process" button

Actual Results:
java.lang.NullPointerException
at org.opencastproject.workflow.handler.AppendWorkflowOperationHandler.resume(AppendWorkflowOperationHandler.java:101)
at org.opencastproject.workflow.impl.WorkflowOperationWorker.resume(WorkflowOperationWorker.java:257)
at org.opencastproject.workflow.impl.WorkflowOperationWorker.execute(WorkflowOperationWorker.java:143)
at org.opencastproject.workflow.impl.WorkflowServiceImpl.runWorkflowOperation(WorkflowServiceImpl.java:766)
at org.opencastproject.workflow.impl.WorkflowServiceImpl.process(WorkflowServiceImpl.java:1661)
at org.opencastproject.workflow.impl.WorkflowServiceImpl$JobRunner.call(WorkflowServiceImpl.java:2056)
at org.opencastproject.workflow.impl.WorkflowServiceImpl$JobRunner.call(WorkflowServiceImpl.java:2022)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
at java.lang.Thread.run(Thread.java:680)

Expected Results:
Selected workflow is executed

Workaround (if any):
None

This is actually a regression caused by

Activity

Show:
Greg Logan
August 19, 2013, 6:06 PM

Merged into 1.4.x with rev 15403.

Rubén Pérez
September 10, 2013, 6:23 PM

I have committed the constraint removal that Christoph missed in his previous commit as rev. 15650.

Greg Logan
September 12, 2013, 8:36 PM

Ruben, does this constraint exist in a 1.3 DB? Do we need to update the conversion scripts as well? Merged your change in as rev 15707, but leaving this issue open. Please resolve as fixed and reviewed if we don't need to change the scripts, otherwise go ahead and bounce it back to me.

Greg Logan
September 27, 2013, 5:08 PM

Committed the fix for the upgrade scripts into trunk with rev 15821. Need to test the postgres ones though, so I'm going to leave this open.

Greg Logan
October 10, 2013, 6:24 PM

This is now done, per the testing done as part of MH-9910.

Fixed and reviewed

Assignee

Greg Logan

Reporter

Christoph Driessen

Severity

Non Functioning

Tags (folksonomy)

Components

Fix versions

Affects versions

Priority

Major
Configure