Typo in embed-hybrid-initialize.js keyboardListener()?

Steps to reproduce

I just noticed this oddity [1] when comparing embed-hybrid-initialize.js with player-multi-hybrid-initialize.js. There are a lot of subtle differences in those scripts.

/**
@memberOf Opencast.Initialize
@description Keylistener.
*/
function keyboardListener()
{
setKeys();
$(document).keyup(function (event)
{
if (event.altKey === true && event.ctrlKey === true)
{
if (event.which === KEY_M ||
event.which === KEY_m)
{
Opencast.Player.doToggleMute();
}
if (event.which === KEY_0 ||
event.which === KEY_0 || <--- typo
event.which === KEY_2 ||

From similar code in player-multi-hybrid-initialize.js

/**
@memberOf Opencast.Initialize
@description Keylistener.
*/
function keyboardListener()
{
setKeys();
$(document).keyup(function (event)
{
if (event.altKey === true && event.ctrlKey === true)
{
if (event.which === KEY_M ||
event.which === KEY_m)
{
Opencast.Player.doToggleMute();
}
if (event.which === KEY_0 ||
event.which === KEY_1 || <-- KEY_1
event.which === KEY_2 ||

[2] https://opencast.jira.com/svn/MH/trunk/shared-resources/js/player/embed-hybrid-initialize.js

Activity

Show:
Former user
September 16, 2013, 12:41 PM

r15726 to remove duplicate KEY_0, add KEY_1 to keyboardListener

Former user
September 16, 2013, 1:04 PM

Greg, I put this as cosmetic issue because its clear that there was a typo but its not clear if it actually fixes anything.

Greg Logan
September 24, 2013, 7:20 PM

Merged into 1.4.x with rev 15798.

Fixed and reviewed

Assignee

Former user

Reporter

Former user

Severity

Incorrect Documentation

Tags (folksonomy)

Components

Fix versions

Affects versions

Priority

Major
Configure